[WC-3114] CheckboxRadio: Validation alert addition #1922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
adjust with #1905 |
yordan-st
force-pushed
the
fix/WC-3114_CheckboxRadio-validation
branch
from
b28f651 to
4c40b40
Compare
yordan-st
force-pushed
the
fix/WC-3114_CheckboxRadio-validation
branch
from
86d2e6c to
e229a45
Compare
gjulivan
reviewed
Oct 3, 2025
| disabled={isReadOnly} | ||
| tabIndex={tabIndex} | ||
| onChange={e => handleChange(optionId, e.target.checked)} | ||
| aria-describedby={selector.validation ? errorId : undefined} |
There was a problem hiding this comment.
difference with combobox,
i think aria-describeby and aria-invalid should be on the component with radiogroup role. not on each input.
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Reference/Roles/radiogroup_role
@HedwigAR please confirm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
What should be covered while testing?