-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EcoWitt WH31B support by modifying WH31E #1732
Conversation
Closing due to instability. Will reopen after fixes in place. |
Notes:
|
Implementing feedback from @zuckschwerdt
Thanks @zuckschwerdt for friendly feedback. Instability seems resolved with your suggestions. Not confident I matched what you were looking for with crc-error distinction recommendation. |
Looks mostly good, thanks! I meant to say: just change the error strings, e.g. "WH31E bad CRC" to "WH31E/WH31B bad CRC", there is no real need to have a switch on the msg_type there (just Perhaps we should keep CRC/SUM separate, so e.g. |
@zuckschwerdt Could you please take another look? |
Added samples here: merbanan/rtl_433_tests#394 , https://github.com/bitfliq/rtl_433_tests/tree/EcoWitt-WH31B .
This code worked for extracting data from WH31B - but I was unable to verify that it did not break the other devices.
Thanks for all of your hard work on this fantastic project.