[Fixed] Close subscriber on worker shutdown #296
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What?
Try to achieve a graceful shutdown of the
Workerby ensuring thatSubscriberClientis properly closed, as we're still gettingCancelledmessages even with the changes introduced in #295.As an extra, this PR introduces some debug messages and test coverage (for this change and the previous one).
🤔 Why?
As per
SubscriberClientdocumentation:If we check the Python example provided in StreamingPull and high-level client library code samples, we can see that the subscriber is expected to the wrapped in a
withblock to automatically callclose()when done:🔗 Related issue
N/A