Skip to content

STEP4 #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

STEP4 #367

wants to merge 5 commits into from

Conversation

waidonchan
Copy link

@waidonchan waidonchan commented Mar 7, 2025

What

  1. APIを呼び出す__Call an API
  2. 新しい商品を登録する__List a new item
  3. 商品一覧を取得する__Get the List of Items
  4. 画像を登録する__Add Item Images
  5. 商品の詳細を返す__Return Item Details

CHECKS ⚠️

Please make sure you are aware of the following.

  • **The changes in this PR doesn't have private information

@waidonchan waidonchan changed the title STEP4-2 STEP4 Mar 9, 2025
Copy link
Contributor

@task4233 task4233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slackでもお伝えしたとおり、ご自分のリポジトリでPRを作成してください! 🙏
ref: https://mercari.slack.com/archives/C08D8NM1GP3/p1741528425297899?thread_ts=1741511771.656259&cid=C08D8NM1GP3

その後、こちらのPRのcloseをお願いします 🙇
それと、関係ないファイルがPRに含まれていたので、そちらの削除もお願いします 🙏

Copy link
Contributor

@task4233 task4233 Mar 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

関係ないファイルなので削除をお願いします!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ご指摘ありがとうございます!
これでうまくいきましたでしょうか...?お手数をお掛けして申し訳ありません。

@waidonchan waidonchan closed this Mar 10, 2025
@task4233
Copy link
Contributor

ref: waidonchan#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants