Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix time api #235

Merged
merged 4 commits into from
Aug 21, 2024
Merged

Fix time api #235

merged 4 commits into from
Aug 21, 2024

Conversation

goccy
Copy link
Member

@goccy goccy commented Aug 21, 2024

Since google.protobuf.Timestamp does not have time zone information, when we use withLocation() API, the time zone information may be lost if it bypass Go's value ( timestamppb.Timestamp ).
So, I fix this issue with custom Time message ( it keeps time zone information ).

This comment has been minimized.

This comment has been minimized.

Copy link

Code Metrics Report

main (c201922) #235 (18d3c1d) +/-
Coverage 65.5% 65.5% -0.0%
Code to Test Ratio 1:0.3 1:0.3 +0.0
Test Execution Time 7m5s 6m50s -15s
Details
  |                     | main (c201922) | #235 (18d3c1d) |  +/-  |
  |---------------------|----------------|----------------|-------|
- | Coverage            |          65.5% |          65.5% | -0.0% |
  |   Files             |             71 |             71 |     0 |
  |   Lines             |          11825 |          11971 |  +146 |
+ |   Covered           |           7746 |           7837 |   +91 |
+ | Code to Test Ratio  |          1:0.3 |          1:0.3 |  +0.0 |
  |   Code              |          37064 |          37260 |  +196 |
+ |   Test              |          12892 |          12984 |   +92 |
+ | Test Execution Time |           7m5s |          6m50s |  -15s |

Code coverage of files in pull request scope (80.4% → 72.5%)

Files Coverage +/-
compiler/compiler.go 79.7% 0.0%
grpc/federation/cel/lib.go 100.0% 0.0%
grpc/federation/cel/time.go 68.3% -9.0%

Reported by octocov

Copy link
Contributor

@shuheiktgw shuheiktgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙆‍♂️

@goccy goccy merged commit 346ef10 into main Aug 21, 2024
4 checks passed
@goccy goccy deleted the fix-time-api branch August 21, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants