Support Strings CEL library #245
Conversation
This comment has been minimized.
This comment has been minimized.
pikachu0310
force-pushed
the
strings
branch
from
9ad5ba4
to
4ec156e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
grpc/federation/cel/strings.go
Outdated
| }, | ||
| ), | ||
| ), | ||
| // func Cut(s, sep string) (before, after string, found bool) |
There was a problem hiding this comment.
What is this comment for? 🤔 Do we miss the Cut function?
There was a problem hiding this comment.
Sorry for the lack of explanation in the comments. I left a comment for the functions I determined to be impossible to implement. Except for Cut, the other comments are for functions that have arguments of types (like Go's func type) that cannot be received by CEL. As for Cut, I concluded it was impossible to implement because it needs to return two variables.
Is there any way to return two variables in this case?
There was a problem hiding this comment.
We talked on this point directly and decided to update the comments to clarify why we cannot implement those functions.
There was a problem hiding this comment.
Do we miss the Cut function?
Regarding "Cut," I found that it's feasible to implement, so I added the implementation.
This comment has been minimized.
This comment has been minimized.
Code Metrics Report
Details | | main (b948f38) | #245 (5cec434) | +/- |
|---------------------|----------------|----------------|-------|
+ | Coverage | 65.8% | 66.0% | +0.2% |
| Files | 74 | 75 | +1 |
| Lines | 12347 | 12418 | +71 |
+ | Covered | 8123 | 8192 | +69 |
+ | Code to Test Ratio | 1:0.3 | 1:0.4 | +0.0 |
| Code | 38141 | 38524 | +383 |
+ | Test | 13210 | 13878 | +668 |
- | Test Execution Time | 7m29s | 7m44s | +15s |Code coverage of files in pull request scope (100.0% → 97.8%)
Reported by octocov |
Provide functionalities similar to Go's strings using the grpc.federation.strings library.
#159