Update CI workflow - #55
Merged
Merged
Conversation
mgi388
marked this pull request as draft
October 4, 2025 08:15
mgi388
marked this pull request as ready for review
October 4, 2025 08:27
Contributor
Author
|
@merwaaan this CI update PR passes now, ready for review when you get a chance. |
Owner
|
Thanks again @mgi388 :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #54 (comment).
I first copied the file from https://github.com/TheBevyFlock/bevy_new_2d/blob/9fd68f61dd9c31f8a73d033fdfc9e0a33dc23a88/.github/workflows/ci.yaml#L1-L186 and deleted
check-webbut then decided that because that's a game template maybe it's not suitable. I know that benfrankel is a contributor to that repo, so I went and looked at one of his libraries: https://github.com/benfrankel/pyri_tooltip.I then updated the PR here, instead copying pyri_tooltip's ci.yaml and going from there to make it pass CI.
The PR commit history shows the changes I made if that's useful to see.