Add: multi-player cursors to the site #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Khusham Bansal <[email protected]>
|
leecalcote
previously approved these changes
Jan 28, 2026
Member
leecalcote
left a comment
leecalcote
left a comment
There was a problem hiding this comment.
Looks great! The cursors are fit right inside of the canvas.
We have them being displayed duplicately (each of them twice), but other than that, this is good.
Member
|
leecalcote
reviewed
Jan 28, 2026
leecalcote
reviewed
Jan 28, 2026
|
|
||
| <div class="hero-visual"> | ||
| <div class="canvas-preview glass--dark" data-float> | ||
| <div class="cursor-layer" data-cursors="0,1,2,3" |
Member
There was a problem hiding this comment.
Can we reduce the z-index to 10? 15?
Please ensure that only one copy of each cursor is visible.
Contributor
Author
There was a problem hiding this comment.
Thanks for points out the mistake. I have fixed the duplicate error.
Signed-off-by: Khusham Bansal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
Add colored and named multi-player cursors to the site
Signed commits