-
Notifications
You must be signed in to change notification settings - Fork 9
feat: update community section cursors and enhance multi-player curso… #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…r functionality - Changed cursor data-cursors attribute in community section from "0,1" to "4,1". - Updated hero-glass section cursor layer to include an additional cursor (4). - Modified cursor-1.svg to change the status text from "Syncing" to "Collaboration". - Added new cursor-5.svg with unique design. - Updated multi-player cursors script: - Renamed cursor for Sarah to Aditya. - Added new cursor for Sara Lin. - Adjusted edge padding and added random interval factors for cursor movement. - Refactored cursor animation logic for improved performance and independence. Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Updates the multi-player cursor visuals and animation behavior to support additional collaborators and improved cursor movement in the hero and community sections.
Changes:
- Extended the cursor set (including a new
cursor-5.svg) and wired it into the hero and community sections via updateddata-cursorsattributes. - Updated the hero header status text from “Syncing” to “Collaboration” and adjusted the first cursor SVG text to match.
- Refactored the cursor animation script to use independent randomized timers per cursor, updated edge padding, and added interval randomization for more organic motion.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| static/scripts/multi-player-cursors.js | Extends cursor configuration, introduces per-cursor randomized scheduling and improved bounded random positioning to drive the new and updated cursors. |
| layouts/partials/section/hero-glass.html | Adds the fifth cursor to the hero visual and updates the status label to “Collaboration” to align with the new cursor visuals. |
| layouts/partials/section/community.html | Switches the community header cursors to use the new cursor index and existing one, showcasing the expanded cursor set. |
| static/images/cursors/cursor-1.svg | Updates the text glyphs to reflect the new “Collaboration” status while preserving existing styling. |
| static/images/cursors/cursor-5.svg | Adds a new cursor SVG asset used in the updated multi-player cursor configuration. |
Comments suppressed due to low confidence (1)
static/scripts/multi-player-cursors.js:39
- The
cursorsarray declared here is now only used forpushinside theforEachloop and never referenced afterward, which makes it effectively dead code after the refactor away from the shared interval; consider removing thecursorsarray (and the correspondingpush) to keepinitCursorsminimal and avoid confusion about a shared cursor collection.
const cursors = [];
cursorIndices.forEach((index) => {
if (index >= CURSORS.length) return;
const cursorData = CURSORS[index];
const cursorElement = createCursorElement(cursorData);
container.appendChild(cursorElement);
cursors.push(cursorElement);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Lee Calcote <leecalcote@gmail.com>
…r functionality
Notes for Reviewers
Signed commits