Skip to content

Conversation

@acald-creator
Copy link
Contributor

@acald-creator acald-creator commented Apr 20, 2023

Description

This PR:

  • Update meshery-adapter-library and meshkit
  • Remove OAM configuration to use MeshModel directly
  • Fix minor misspelling
  • Turned on debug in logger
  • The NGINX Service Mesh's version is hardcoded and will needs to be changed to be declared in a variable. NGINX Service Mesh have moved away from downloading releases from the GitHub Releases, it looks like, and now you would download the raw file from within the repo itself. Their versioning has changed as well.

See repo: https://github.com/nginxinc/helm-charts/tree/master/stable

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@stale
Copy link

stale bot commented Jul 9, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Jul 9, 2023
@leecalcote leecalcote added the issue/willfix This issue will be worked on label Jul 9, 2023
@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

issue/willfix This issue will be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants