Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search (filter) for an specific Integration on Homepage's Integrations section #1807

Closed
wants to merge 11 commits into from

Conversation

shubhusion
Copy link

Description

This PR fixes #1798

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented Jul 6, 2024

Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit 24ef911
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/6693d7493fa5d200088a8035
😎 Deploy Preview https://deploy-preview-1807--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shubhusion shubhusion changed the title Patch 1 Add search (filter) for an specific Integration on Homepage's Integrations section Jul 6, 2024
@shubhusion shubhusion marked this pull request as ready for review July 6, 2024 08:49
@shubhusion shubhusion changed the base branch from master to willcalcote/ofodile-peace July 6, 2024 19:55
@shubhusion shubhusion changed the base branch from willcalcote/ofodile-peace to master July 6, 2024 19:56
@shubhusion shubhusion closed this Jul 7, 2024
@shubhusion shubhusion reopened this Jul 7, 2024
@vishalvivekm
Copy link
Member

Thank you for your contribution.
Let's discuss this on Websites' call. Adding this as an agenda item into the meeting minutes.

@vishalvivekm
Copy link
Member

@shubhusion
Please remove commits not related to this PR.

@shubhusion
Copy link
Author

shubhusion commented Jul 15, 2024

@shubhusion Please remove commits not related to this PR.

@vishalvivekm commits not related to PR just appear here but there are no changes in the PR wrt to those commits. It looks like a bug. there is only 1 file change which is related to the PR. Merging will only change the concerned file where changes are needed.

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shubhusion Please remove commits not related to this PR.

@vishalvivekm commits not related to PR just appear here but there are no changes in the PR wrt to those commits. It looks like a bug. there is only 1 file change which is related to the PR. Merging will only change the concerned file where changes are needed.

@shubhusion, again, remove extraneous commits. Sync your fork and branch with head on master. Your PR should only include your commits / commits pertinent to the PR at-hand.

@leecalcote leecalcote removed the request for review from GaganpreetKaurKalsi July 21, 2024 14:04
@shubhusion shubhusion closed this Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add search (filter) for an specific Integration on Homepage's Integrations section
5 participants