Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search (filter) for an specific Integration on Homepage's Integrations section #1829

Closed
wants to merge 85 commits into from

Conversation

shubhusion
Copy link

Description

This PR fixes #1798

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented Jul 27, 2024

Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit f4c4e31
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/66aa318dfdebeb00086fa3d8
😎 Deploy Preview https://deploy-preview-1829--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shubhusion shubhusion marked this pull request as ready for review July 27, 2024 19:24
@leecalcote
Copy link
Member

@hargunkaur286 you might offer review.

@hargunkaur286 hargunkaur286 self-requested a review July 29, 2024 19:46
Copy link
Contributor

@hargunkaur286 hargunkaur286 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shubhusion Can you share screenshots of the changes?
The images are missing in the deploy preview
Screenshot 2024-07-31 at 4 29 54 PM

@shubhusion
Copy link
Author

@shubhusion Can you share screenshots of the changes? The images are missing in the deploy preview Screenshot 2024-07-31 at 4 29 54 PM

@hargunkaur286 I have only added the search filter present above the images

image

@hargunkaur286
Copy link
Contributor

@shubhusion Can you share screenshots of the changes? The images are missing in the deploy preview Screenshot 2024-07-31 at 4 29 54 PM

@hargunkaur286 I have only added the search filter present above the images

image

okay, can you share a full screenshot please

shubhusion and others added 21 commits July 31, 2024 18:10
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: Shubham Upadhyay <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: Shubham Upadhyay <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: l5io <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: l5io <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: l5io <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: kanishk6103 <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: kanishk6103 <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: l5io <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: Hargun Kaur <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: Yash Sharma <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: Yash Sharma <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: Yash Sharma <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: Yash Sharma <[email protected]>
Signed-off-by: shubhusion <[email protected]>
leecalcote and others added 23 commits July 31, 2024 18:11
Signed-off-by: l5io <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: l5io <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: l5io <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: l5io <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: l5io <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: l5io <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: l5io <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: l5io <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: l5io <[email protected]>
Signed-off-by: shubhusion <[email protected]>
Signed-off-by: l5io <[email protected]>
Signed-off-by: shubhusion <[email protected]>
…calculates category count

Signed-off-by: kanishk6103 <[email protected]>
Signed-off-by: shubhusion <[email protected]>
@shubhusion
Copy link
Author

Hi @hargunkaur286,

I have made the necessary changes. However, while rebasing, I commited an error that caused the commits of other collaborators to merge into this PR. So, I have closed this PR and created a new one.

Could you please review the new PR? Thanks!

PR: #1837

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add search (filter) for an specific Integration on Homepage's Integrations section