-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set custom log level, and added formatting fields #340
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Antonette Caldwell <[email protected]>
181903f
to
d804beb
Compare
Signed-off-by: Antonette Caldwell <[email protected]>
Updating reviewers... |
How can i test this changes in my local |
…/logrus-levels
@suhail34 You can checkout this branch locally and then in meshery/meshery, point your go.mod to your local meshkit using replace. Then you can start Meshery and see the logs. Since there are new functions that are added, you can try replacing current .Info, .Error functions with these new functions to see how the logs come out. @nebula-aac It would be nicer if could have some unit tests here. |
@nebula-aac Do you have some screenshot examples of how the error logs will look like running it locally? |
Hey @Revolyssup I tested this is the ss |
I was thinking like if we can do the same as syslogformat and add in setformatter disableTimestamp: true something like this
|
@suhail34 Also test it with Meshery server. I hope the logs don't get too big with 5-6 lines per error/warn log. |
I'll have to make some updates on this PR. I'll provide some screenshots |
If we want to keep it to the minimum on the logs for |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@nebula-aac Any updates ? |
I think we could define the init funciton and disable the timestamp so that globally all of the logrus has timestamp disabled |
Description
This PR adds
Warn
andError
Notes for Reviewers
Signed commits