Update Svg Helper function with Read Write mutex w/signoff #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jougan-0 <[email protected]>
1 task
Signed-off-by: Jougan-0 <[email protected]>
MUzairS15
reviewed
Sep 18, 2024
| @@ -495,3 +496,35 @@ func ConvertMapInterfaceMapString(v interface{}) interface{} { | |||
|
|
|||
| return v | |||
| } | |||
|
|
|||
| func WorkerPool[T any](tasks []T, workerFunc func(T), maxWorkers int) { | |||
There was a problem hiding this comment.
Will you revisit the workerFunc return type? How is the error handling done?
There was a problem hiding this comment.
Yes, I'll see how to improve the error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #
PR needs to be merged to fix conflict with concurrency reduce registration time.
Notes for Reviewers
Signed commits