-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Minify and Flatten for In-cluster deployment with Minikube #588
base: master
Are you sure you want to change the base?
Conversation
…or=Alero Awani <[email protected]> Signed-off-by: Alero Awani <[email protected]>
…uthor=Alero Awani <[email protected]> Signed-off-by: Alero Awani <[email protected]>
Thanks for tackling this, @Alero-Awani |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Alero-Awani Can you fix these lint failures? then we are good to go. |
if err != nil { | ||
return nil, ErrValidateConfig(err) | ||
return nil, nil, err |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please reuse/define a new meshkit error.
if err != nil { | ||
return nil, ErrLoadConfig(err) | ||
return nil, nil, err |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please reuse/define a new meshkit error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright Noted! Thank you for the review 😃
Description
This PR introduces a central function
ProcessConfig
for processing kubeconfig files, encapsulating the functionality for loading, validating, and writing kubeconfig files, whether from a file location or a []byte input.The function has been integrated into the
DetectKubeConfig
, addressing this issue which specifically occurs when running the commandmesheryctl system start -p Kubernetes
.Fixes #11546
Signed commits