-
-
Notifications
You must be signed in to change notification settings - Fork 305
docs: add information about spotless for code formatting #2622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Clarify that spotless is used for automated code formatting and provide commands for applying formatting and installing a pre-push Git hook. Signed-off-by: James Rich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel targeted 😅
I've been meaning to, you're a good reminder ;) |
Huh I'm actually getting a failure from within Spotless' install task:
|
mm i do remember having to run it with |
The command to install the Spotless Git pre-push hook was updated to include `--no-configuration-cache` to ensure it runs correctly. Signed-off-by: James Rich <[email protected]>
Ah I can probably fix that on Spotless' end, they just need to grab the root dir before executing the task |
Re: spotless - diffplug/spotless#2586 Once that gets merged in and we update spotless I'll update our docs so that we don't need the config cache disable flag. I tested with maven-local install and it worked fine 👍 |
Adds spotless doco to
CONTRIBUTORS.md
Clarify that spotless is used for automated code formatting and provide commands for applying formatting and installing a pre-push Git hook.