Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes channel message mark as read lagging the channel message list view #1107

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

RCGV1
Copy link
Member

@RCGV1 RCGV1 commented Feb 18, 2025

What changed?

Added an async function with debounce to handle the read message.

Why did it change?

With a large amount of messages in a channel, scrolling would be very laggy.

How is this tested?

Tested on one iPhone with my fix and another iPhone without it. I sent around 33 messages to test what would happen.

Screenshots/Videos (when applicable)

Before Fix:

RPReplay_Final1739909121.MP4

After Fix:

ScreenRecording_02-18-2025.12-09-07_1.MP4

Checklist

  • My code adheres to the project's coding and style guidelines.
  • I have conducted a self-review of my code.
  • I have commented my code, particularly in complex areas.
  • I have made corresponding changes to the documentation.
  • I have tested the change to ensure that it works as intended.

@RCGV1 RCGV1 changed the base branch from main to fixReadIndicator February 18, 2025 20:24
@RCGV1 RCGV1 merged commit 83d261c into meshtastic:fixReadIndicator Feb 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant