Fix Typescript errors #486
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewCmatt
changed the title
danditomaso
reviewed
Feb 26, 2025
| @@ -184,8 +183,8 @@ export const CreateWaypointDialog = ({ | |||
| const handlePositionUpdate = useMemo( | |||
| () => | |||
| debounce<(e: MarkerDragEvent) => void>((e) => { | |||
| setWaypointPosition(e.lngLat); | |||
| flyToPosition(e.lngLat); | |||
| setWaypointPosition(e.lngLat as LngLat); | |||
There was a problem hiding this comment.
Casting is against a TypeScript best practice, can this be inferred or the MarkerDragEvent unioned with another type that would provide Lat & Long?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this repo fails the
tsccheck. We currently don't run this in CI except on build, so we haven't caught it until now.This PR:
ui:lint"lint" check. This is covered byui:check.tsccheck to theui:checkscripttscfromui:buildendpoint. This will be run on every MR from now on, andvite buildcompiles typescript where needed.tscerrorstsc --noEmitpassing!