Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow port number to be specified with tcp hostname #673

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

djholt
Copy link
Contributor

@djholt djholt commented Sep 17, 2024

This is minor but useful when a different port number needs to be specified (when tunneling over SSH, for example).

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.72%. Comparing base (584a14f) to head (5cc9627).
Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
meshtastic/__main__.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #673      +/-   ##
==========================================
+ Coverage   60.70%   60.72%   +0.02%     
==========================================
  Files          24       24              
  Lines        3667     3672       +5     
==========================================
+ Hits         2226     2230       +4     
- Misses       1441     1442       +1     
Flag Coverage Δ
unittests 60.72% <80.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ianmcorvidae
Copy link
Contributor

Looks like the test failure is unrelated, to do with test fuzzing for some other stuff. This looks good, thanks!

@ianmcorvidae ianmcorvidae merged commit 5d6dfb8 into meshtastic:master Sep 18, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants