Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a --set-time command that set's the node time using a provided timestamp or the host system clock #676

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

ianmcorvidae
Copy link
Contributor

@ianmcorvidae ianmcorvidae commented Sep 22, 2024

Now that time isn't set by default and there's an admin message for this, we should be using it/allowing it. Bonus, this allows setting remote node time if I understand it correctly!

ref: meshtastic/firmware#4479

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 21.42857% with 11 lines in your changes missing coverage. Please review.

Project coverage is 60.76%. Comparing base (de657ba) to head (40019a9).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
meshtastic/node.py 9.09% 10 Missing ⚠️
meshtastic/__main__.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #676      +/-   ##
==========================================
- Coverage   60.91%   60.76%   -0.15%     
==========================================
  Files          24       24              
  Lines        3689     3703      +14     
==========================================
+ Hits         2247     2250       +3     
- Misses       1442     1453      +11     
Flag Coverage Δ
unittests 60.76% <21.42%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ianmcorvidae ianmcorvidae merged commit d875a57 into meshtastic:master Sep 22, 2024
9 of 11 checks passed
@ianmcorvidae ianmcorvidae deleted the set-time branch September 22, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants