Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix picojson header file issue #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chenzhiwei
Copy link
Contributor

Use the built-in picojson git submodule instead of system-wide picojson

@@ -0,0 +1 @@
Subproject commit cc130fbcb165ffbc2aa7a7fadfe98ff6ed4120c8
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using the head of PicoJson, you should instead point to PicoJson 1.3.0:
25fc213cca61ea22b3c2e4db8def9927562ba5f7

(We recently updated this dependency).

Use the built-in picojson git submodule instead of system-wide picojson
@chenzhiwei
Copy link
Contributor Author

@kaysoky Thanks, uploaded a new patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants