Skip to content

Conversation

ebsmothers
Copy link
Contributor

@ebsmothers ebsmothers commented Oct 7, 2025

this PR is the culmination of a long and sad story. but we can now run forge tests on GPU runners

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 7, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@3303af5). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #334   +/-   ##
=======================================
  Coverage        ?   64.09%           
=======================================
  Files           ?       79           
  Lines           ?     7760           
  Branches        ?        0           
=======================================
  Hits            ?     4974           
  Misses          ?     2786           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joecummings
Copy link
Member

hey

@ebsmothers
Copy link
Contributor Author

ebsmothers commented Oct 10, 2025

hey

don't look at me actually though this is ready for review

@ebsmothers ebsmothers marked this pull request as ready for review October 10, 2025 22:55
- name: Download and install vLLM and its dependencies
# TODO: this honestly could not be hackier if I tried
run: |
python -m pip install -r .github/packaging/vllm_reqs.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems stable

@ebsmothers ebsmothers changed the title [just testing] GPU CI GPU CI Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants