Skip to content

[NOT FOR LAND] turning off the logging fetchers path #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[NOT FOR LAND] turning off the logging fetchers path #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/forge/controller/provisioner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@

from forge.controller.launcher import BaseLauncher, get_launcher

from forge.observability.metric_actors import get_or_create_metric_logger

from forge.types import ProcessConfig, ProvisionerConfig

logger = logging.getLogger(__name__)
Expand Down Expand Up @@ -263,7 +261,7 @@ def bootstrap(env: dict[str, str]):
self._proc_host_map[procs] = host_mesh

# Spawn local logging actor on each process and register with global logger
_ = await get_or_create_metric_logger(procs)
# _ = await get_or_create_metric_logger(procs)
return procs

async def host_mesh_from_proc(self, proc_mesh: ProcMesh):
Expand All @@ -283,9 +281,9 @@ async def stop_proc_mesh(self, proc_mesh: ProcMesh):
return
async with self._lock:
# Deregister local logger from global logger
if hasattr(proc_mesh, "_local_fetcher"):
global_logger = await get_or_create_metric_logger(proc_mesh)
await global_logger.deregister_fetcher.call_one(proc_mesh)
# if hasattr(proc_mesh, "_local_fetcher"):
# global_logger = await get_or_create_metric_logger(proc_mesh)
# await global_logger.deregister_fetcher.call_one(proc_mesh)

if hasattr(proc_mesh, "_gpu_ids"):
gpu_manager = self._host_gpu_map[proc_mesh._host._host_id]
Expand Down
4 changes: 2 additions & 2 deletions src/forge/observability/metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,8 +436,8 @@ async def init_backends(
self._is_initialized = True

def push(self, key: str, value: Any, reduction: Reduce = Reduce.MEAN) -> None:
if not self._is_initialized:
raise ValueError("Collector not initialized—call init first")
# if not self._is_initialized:
# raise ValueError("Collector not initialized—call init first")

if key not in self.accumulators:
self.accumulators[key] = reduction.accumulator_class(reduction)
Expand Down
Loading