Skip to content

Conversation

svekars
Copy link
Contributor

@svekars svekars commented Oct 7, 2025

  • The docs build workflow now installs torchmonarch instead of a custom monarch wheel, and sets up library and CUDA paths to ensure all dependencies (especially native ones) are available.
  • The ForgeActor class now includes detailed docstrings for its resource attributes (procs, hosts, with_gpus, num_replicas, mesh_name), and the options method provides example usage in the docstring. This makes it easier for users to understand resource configuration for distributed training.
  • Adds a docsting for the Service.stop method
  • Docstrings from Service methods are copied to ServiceActor methods, ensuring complete documentation for Sphinx autodoc.
  • Sphinx configuration changes improve navigation depth

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 7, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@2a6e46f). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #336   +/-   ##
=======================================
  Coverage        ?   63.32%           
=======================================
  Files           ?       78           
  Lines           ?     7716           
  Branches        ?        0           
=======================================
  Hits            ?     4886           
  Misses          ?     2830           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svekars svekars marked this pull request as ready for review October 10, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants