Replaced 9999 with 158, the correct constant for EDIT_EVENT_ADD_EVENT_ART, as defined in the official MusicBrainz Server source#64
Open
invo-coder19 wants to merge 1 commit intometabrainz:masterfrom
Conversation
…IT_EVENT_ADD_EVENT_ART)
Member
|
Can one of the admins verify this patch? |
Member
|
@brainzbot ok to test |
mwiencek
requested changes
Mar 2, 2026
Member
mwiencek
left a comment
There was a problem hiding this comment.
thanks, just fix the comment since EDIT_COVER_ART_ADD isn't the name used in MBS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abstract
Resolves a long-standing
FIXMEcomment in the test SQL fixture by replacingthe placeholder edit type ID
9999with the correct, verified value158(
EDIT_EVENT_ADD_EVENT_ART), sourced from the official MusicBrainz Serverconstants file.
Problem
In [test/add_data.sql], the
INSERT INTO musicbrainz.editstatement used aplaceholder value of
9999for the "add event artwork" edit type, with acomment acknowledging that the real value was unknown at the time of writing: