Skip to content

Replaced 9999 with 158, the correct constant for EDIT_EVENT_ADD_EVENT_ART, as defined in the official MusicBrainz Server source#64

Open
invo-coder19 wants to merge 1 commit intometabrainz:masterfrom
invo-coder19:fix
Open

Replaced 9999 with 158, the correct constant for EDIT_EVENT_ADD_EVENT_ART, as defined in the official MusicBrainz Server source#64
invo-coder19 wants to merge 1 commit intometabrainz:masterfrom
invo-coder19:fix

Conversation

@invo-coder19
Copy link

Abstract

Resolves a long-standing FIXME comment in the test SQL fixture by replacing
the placeholder edit type ID 9999 with the correct, verified value 158
(EDIT_EVENT_ADD_EVENT_ART), sourced from the official MusicBrainz Server
constants file.

Problem

In [test/add_data.sql], the INSERT INTO musicbrainz.edit statement used a
placeholder value of 9999 for the "add event artwork" edit type, with a
comment acknowledging that the real value was unknown at the time of writing:

@brainzbot
Copy link
Member

Can one of the admins verify this patch?

@mwiencek
Copy link
Member

mwiencek commented Mar 2, 2026

@brainzbot ok to test

Copy link
Member

@mwiencek mwiencek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, just fix the comment since EDIT_COVER_ART_ADD isn't the name used in MBS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants