BB-887: fix: Prevent navigation from invalid tabs in Unified Form#1259
Open
atharvsp02 wants to merge 1 commit intometabrainz:masterfrom
Open
BB-887: fix: Prevent navigation from invalid tabs in Unified Form#1259atharvsp02 wants to merge 1 commit intometabrainz:masterfrom
atharvsp02 wants to merge 1 commit intometabrainz:masterfrom
Conversation
Contributor
|
Hi @atharvsp02 Thank you for opening this PR.... Please fill in the "AI usage" section in the PR template, it is there for a reason... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Ticket: BB-887
Users can navigate away from a tab in the Unified Form even if they have left required fields empty or invalid. This allows them to reach the final Submit tab, but find the "Submit" button disabled with no clear indication of what went wrong.
Solution
Navigation is now blocked when leaving a tab with validation errors:
Areas of Impact
unified-form.tsx- Tab validation and navigation blockingnavbutton.tsx- Added error alert above navigation buttonstype.ts- AddederrorMessageprop toNavButtonsPropsScreenshot
Cover Tab(when some required fields are empty or invalid)
Content Tab(reached while previous tabs are empty)
Let me know if you have any suggestions or changes you’d like me to make.
Testing
AI usage