BB-876: feat: Add script option for aliases and name section#1278
Open
atharvsp02 wants to merge 1 commit intometabrainz:masterfrom
Open
BB-876: feat: Add script option for aliases and name section#1278atharvsp02 wants to merge 1 commit intometabrainz:masterfrom
atharvsp02 wants to merge 1 commit intometabrainz:masterfrom
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently there is no script option for aliases and entity names. Languages like Serbian use multiple scripts like Latin and Cyrillic and right now there is no way to tell which script a title is written in.
Solution
Added a Script dropdown to the alias editor and the main name section, following the same pattern as the existing Language field.
Database:
musicbrainz.scripttable to the schemascript_idcolumn tobookbrainz.aliasServer:
loadScriptsmiddleware (same asloadLanguages)constructAliasesto include `scriptIdFrontend:
ScriptFieldcomponent with grouped options (Frequently Used and Other) and recently usedThis PR relies on the Script model and alias relationship from metabrainz/bookbrainz-data-js #338.
Areas of impact
musicbrainz.sql,up.sql,down.sql- Database schema and migrationmiddleware.ts,entityRouteUtils.tsx- Server data loading and prop passingauthor.ts,edition.ts,edition-group.ts,publisher.ts,series.ts,work.ts,merge.ts,unifiedform.ts- Routing middleware updatesentity.tsx- Server data parsingscript-field.tsx- New UI componentalias-editor.js,alias-modal-body.tsx,alias-row.js- Alias UI updatesactions.ts,reducer.js- State management for alias and name sectionname-section.js- Name section UI updatesScreenshots
Script dropdown in Name Section
Script dropdown in Alias Editor
AI usage
If you did use AI:
Action
sql/migrations/2026-03-30/up.sql