Parameterized queries for raw SQL#1281
Open
eulerbutcooler wants to merge 1 commit intometabrainz:masterfrom
Open
Parameterized queries for raw SQL#1281eulerbutcooler wants to merge 1 commit intometabrainz:masterfrom
eulerbutcooler wants to merge 1 commit intometabrainz:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Four
knex.raw()calls use JS template literal interpolation to embed values directly into SQL query strings which is not the standard way of doing a knex.raw() query.src/server/helpers/collections.js-getCollectionItems()interpolatescollectionId,size, andfromsrc/server/helpers/achievement.js-processSprinter()interpolateseditorID, getConsecutiveDaysWithEdits() interpolateseditorIDanddayssrc/server/routes/editor.tsx-getProgress()interpolateseditorIDAll though none of these queries are prone to SQL injectioning as all values either come from an authenticated session or are validated/hardcoded it would still be a decent code improvement.
Solution
Replace all string interpolation in knex.raw() with parameterized placeholders(?) and value arrays.
AI usage