Skip to content

BB-841 : fix error handling and refactored handlesubmit from promise .then/catch to async/await with try catch#1293

Open
garvthakre wants to merge 1 commit intometabrainz:masterfrom
garvthakre:BB-841-revision-error-handling
Open

BB-841 : fix error handling and refactored handlesubmit from promise .then/catch to async/await with try catch#1293
garvthakre wants to merge 1 commit intometabrainz:masterfrom
garvthakre:BB-841-revision-error-handling

Conversation

@garvthakre
Copy link
Copy Markdown
Contributor

Problem

BB-841 : handleSubmit in revision.js used an old Promise .then()/.catch() chain. The .catch block incorrectly used res as if it were a response object, but a thrown Promise error is an Error object . so res.body would crash.this was mentioned by @MonkeyDo in the PR #1160 (it is closed for now because the fork was deleted)

Solution

Converted handleSubmit to async/await with try/catch. Error is now correctly extracted via err?.response?.body?.error || err?.message || err as recommended in the superagent docs and per @MonkeyDo's review on that PR.

  • I have run the code and manually tested the changes

AI usage

🔰 If you used AI at all, you must disclose it, and what for, such as:

Used Copilot when writing the tests I added to testfile.js

  • I did not use any AI
  • I have used AI in this PR (add more details below)

Action

No special action required for this .

@garvthakre
Copy link
Copy Markdown
Contributor Author

hey @MonkeyDo , its a small refactor change can u have a look at this .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant