BB-841 : fix error handling and refactored handlesubmit from promise .then/catch to async/await with try catch#1293
Open
garvthakre wants to merge 1 commit intometabrainz:masterfrom
Conversation
….then/catch to async/await with try catch
Contributor
Author
|
hey @MonkeyDo , its a small refactor change can u have a look at this . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
BB-841 : handleSubmit in revision.js used an old Promise .then()/.catch() chain. The .catch block incorrectly used res as if it were a response object, but a thrown Promise error is an Error object . so res.body would crash.this was mentioned by @MonkeyDo in the PR #1160 (it is closed for now because the fork was deleted)
Solution
Converted handleSubmit to async/await with try/catch. Error is now correctly extracted via err?.response?.body?.error || err?.message || err as recommended in the superagent docs and per @MonkeyDo's review on that PR.
AI usage
🔰 If you used AI at all, you must disclose it, and what for, such as:
Action
No special action required for this .