Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBS-11548: Show recent additions voted by auto-editors #2029

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yvanzo
Copy link
Contributor

@yvanzo yvanzo commented Apr 1, 2021

Implement MBS-11548

Require an implicit review by auto-editors through a yes vote or a direct approval of the added cover art to display recent additions on the front page.

Implementation note: Approvals are too rare to refresh recent additions often enough. That’s why it also checks for yes votes (not necessarily the last vote though).

Checklist for author

  • Tested with pink data

Action

  1. Inform auto-editors about this new side effect

Require an implicit review by auto-editors through a yes vote or a
direct approval of the added cover art to display recent additions on
the front page.

Approvals are too rare to refresh recent additions often enough. That’s
why it also checks for yes votes (not necessarily the last vote though).
@yvanzo yvanzo requested review from mwiencek and reosarevok April 1, 2021 18:27
@reosarevok
Copy link
Member

I don't like this implementation because it feels that, as an autoeditor, I'm supposed to not vote for a correct edit if it contains art that I feel shouldn't be on the front page. We shouldn't discourage already very rare voting.

@yvanzo
Copy link
Contributor Author

yvanzo commented Apr 1, 2021

@reosarevok: The initial proposition was to take all yes votes into account, not just auto-editors, so it does not prevent non auto-editors to vote for these edits. Let’s keep the discussion under the ticket so that the whole community can take part into it.

@yvanzo yvanzo added this to the 2021-11-08 milestone Oct 20, 2021
@reosarevok reosarevok removed this from the 2021-11-15 milestone Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants