MBS-1801 (I): SQL additions to support in-site social aspects #2108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwiencek
reviewed
May 19, 2021
This adds five tables to their own messaging namespace. message is for user-to-user messages - as such, it has a sender and a receiver, plus a title and content. It also has an optional parent column which will store the previous message when there is a message thread. hidden_message allows for either the sender or receiver (or both) to "remove" a message from their messaging list. This is less complex than removing the message outright (on demand from which of the users?) and makes sure that the content is available to an admin to verify abuse without the user needing to keep the abusive message in their inbox. notification is for system notifications. These could be implemented as messages from ModBot, but having them in a separate table seems simpler since we are likely to want to display them separately. It also makes it easier to deal with them separately if we decide to, for example, make notifications be removed some time after being read. In preparation for such a possibility, "read" is a timestamp for notification, but just a boolean for message where we expect to only remove (hide) messages on request by the sender or receiver. edit_thanks and edit_note_thanks allow editors to thank others for their edits and edit notes, respectively. The thanking itself is stored in these tables, and I expect it should be possible for a user to check all their sent or received thanks later on. The user being thanked should also be notified, so on a new thanking a notification should be inserted in the notification table. Whether this will happen via a trigger or through code can be decided later.
mwiencek
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MBS-1801
This adds five tables to their own messaging namespace.
messageis for user-to-user messages - as such, it has a sender and a receiver, plus a title and content. It also has an optionalparent column which will store the previous message when there is a message thread.
hidden_messageallows for either the sender or receiver (or both) to "remove" a message from their messaging list. This is less complex than removing the message outright (on demand from which of the users?) and makes sure that the content is available to an admin to verify abuse without the user needing to keep the abusive message in their inbox.notificationis for system notifications. These could be implemented as messages from ModBot, but having them in a separate table seems simpler since we are likely to want to display them separately. It also makes it easier to deal with them separately if we decide to, for example, make notifications be removed some time after being read.In preparation for such a possibility,
readis a timestamp fornotification, but just a boolean formessagewhere we expect to only remove (hide) messages on request by the sender or receiver.edit_thanksandedit_note_thanksallow editors to thank others for their edits and edit notes, respectively. The thanking itselfis stored in these tables, and I expect it should be possible for a user to check all their sent or received thanks later on.
The user being thanked should also be notified, so on a new thanking a notification should be inserted in the notification table. Whether this will happen via a trigger or through code can be decided later.