MBS-8570 / MBS-12012: External-link editor existing error enhancements #2301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reosarevok
changed the title
|
Made some changes to the second commit to better take advantage of the deleted links now staying in state with highlights. |
reosarevok
force-pushed
the
MBS-12010
branch
2 times, most recently
from
b517782 to
f7f8d5f
Compare
|
I think the errors this is hitting in selenium now are mostly connected to MBS-12032 (which I'm not sure how to fix). |
reosarevok
changed the title
|
@reosarevok: Can you please rebase it on current |
|
I can, but I doubt they will, as I said above I think that's because of it hitting MBS-12032. You've played with this code more, do you have any suggestions on how to fix that bug? |
We shouldn't check for duplicates based on both kept and deleted links, since that means the duplicate is still detected even when deleting an already existing dupe. The reason we did this was to avoid an editor deleting a relationship, then adding the exact same relationship. We can still block that by checking it separately only if the link is new or changed, and actually giving a more useful error message than "already exists" that explicitly tells the user to prefer the existing relationship they are deleting.
Example of legitimate use case: Artist "Example" has official homepage at http://example.com from 2010 to 2011 and from 2016 to present (because the homepage was down or elsewhere in the meantime).
This could use a lot more changes, but let's at least get the simple ones done.
Avoids a "Form submission canceled because the form is not connected" console warning.
reosarevok
force-pushed
the
MBS-12010
branch
from
f9dcd4a to
ae56df2
Compare
|
I probably have to review #2322 in the first place? |
|
Well, that's been merged but you can take a look :) The bug existed before that though. |
|
Please ping me when this ends up on beta (related irc chat). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MBS-8570 / MBS-12012
See commit messages.