MBS-13922: Add URL cleanup and validation for Naver Vibe #3463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maxr1998
force-pushed
the
vibe-url-cleanup
branch
from
4dc4b22 to
1af861e
Compare
Maxr1998
force-pushed
the
vibe-url-cleanup
branch
from
1af861e to
b10f6f3
Compare
|
All tests passed until the one that didn't :) (and that crashed it). Will look into why. |
|
Thanks, I unfortunately couldn't find a cause for it yet.. |
|
The regexes in the cleanup were a bit weird, and it was not matching your music.naver URL. AFAICT the intent is just "catch the number, ignore everything after it" so I changed it up a bit to match how we do those things in other cleanups. If there's a deeper meaning we need to keep, let me know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, URL relationships for Naver Vibe aren't validated nor cleaned up to a standard format.
Solution
Implement URL cleanup code for Naver Vibe, ensure that links are only added to their respective allowed entities, and rewrite legacy Naver Music links to the new Vibe format.
Testing
Tested locally by adding various types of Naver Vibe links to artists and releases. Additionally, unit tests have been written.
Currently, the unit tests fail due to a timeout, I'm not sure what is causing that, since it also says that all tests passed.