Update prepositions in tracklist editor warnings #3475
Conversation
Reword tracklist editor warning strings from "used Various Artists on some tracks" to "used Various Artists for some tracks" and from "featured artists on the track titles" to "featured artists in the track titles". Also rename a few variables for consistency.
|
@reosarevok and @mwiencek, mind taking a look? This is as briefly discussed in #3469. |
| @@ -498,22 +498,22 @@ class Medium { | |||
| return self.tracksUnknownToUser() || | |||
| self.tracks().every(t => t.hasTitle()); | |||
| }); | |||
| this.hasVariousArtistTracks = ko.computed(function () { | |||
| this.hasVariousArtistsTracks = ko.computed(function () { | |||
There was a problem hiding this comment.
This one feels debatable; see e.g. https://english.stackexchange.com/questions/497087/can-plural-noun-be-followed-by-another-plural-noun. Since this isn't user-facing, I figure it's probably marginally better for maintainability to use "VariousArtists" here rather than the singular form.
There was a problem hiding this comment.
It does sound a little weird to me pluralized, but I don't have a problem with changing it for consistency.
| <div class="various-artists warning"> | ||
| [%- warning_icon %] | ||
| <p> | ||
| <strong>[% add_colon(l('Warning')) | html_entity %]</strong> | ||
| [% l('You’ve used the {valink|Various Artists} special purpose artist on some tracks below. {valink|Various Artists} should very rarely be used on tracks; please make sure the artists have been entered correctly.', { valink => { href => va_doc_link, target => '_blank' } }) %] | ||
| [% l('You’ve used the {valink|Various Artists} special purpose artist for some tracks below. {valink|Various Artists} should very rarely be used for tracks; please make sure the artists have been entered correctly.', { valink => { href => va_doc_link, target => '_blank' } }) %] |
There was a problem hiding this comment.
"on" is okay here, but "for" sounds slightly more okay to me. Curious what others think, though. :-)
There was a problem hiding this comment.
For this one either sounds fine to me, but I'd actually default to saying "on" here, so I'm honestly not sure if this one is universal enough to warrant changing the string; it may need another native speaker for a tie breaker. :) @Aerozol?
There was a problem hiding this comment.
Curse you, English! I think I would use "for" in conversation, but a web search re. grammar makes me think "on" might be more technically correct (but it wasn't conclusive).
I don't feel comfortable backing one tbh. Don't let it hold back this PR but I made a reddit thread here: https://www.reddit.com/r/EnglishGrammar/comments/1iqa01q/on_vs_for/
If I find a conclusive answer we can add it to our style guidelines, so we (hopefully) must never speak of it again.
There was a problem hiding this comment.
Only one reply (they went with "for", but they don't seem to be an English professor or anything) which implies to me that there is no correct answer - otherwise the internet would have yelled at me by now.
After sleeping on it I think I'm picking "for" as well.
There was a problem hiding this comment.
Thanks for seeking more opinions, @Aerozol!
https://musicbrainz.org/doc/Style/Artist_Credits uses both:
Artist credits should generally follow the actual credit used on the release / track, ...
You should generally enter the credit as it appears on the release, ...
The artist credit for tracks and recordings containing multiple songs by different artists, ...
This feels really subtle to me. I'm wondering if the distinction is that I favor using "on" when the artists/credits are the subject of the sentence:
The artists on this release are all wrong!
and "for" when the focus is on how the artists/credits are being used:
Please don't use this artist for any new releases; I'm trying to clear it out so it will be auto-deleted.
"For" would sound very wrong to me in the first sentence, but "on" sounds almost as good as "for" in the second, so maybe it'd be simplest to just standardize on "on"... :-P
| <div class="feat-titles warning"> | ||
| [%- warning_icon %] | ||
| <p> | ||
| <strong>[% l('Warning:') | html_entity %]</strong> | ||
| [% l('This medium seems to have featured artists on the track titles. These should usually be {featured_style|entered as part of the track artist}.', { featured_style => { href => doc_link('Style/Artist_Credits'), target => '_blank' } }) %] | ||
| [% l('This medium seems to have featured artists in the track titles. These should usually be {featured_style|entered as part of the track artist}.', { featured_style => { href => doc_link('Style/Artist_Credits'), target => '_blank' } }) %] |
There was a problem hiding this comment.
I do agree that the changes from "on the track titles" to "in the track titles" sound more natural to me.
|
I am okay with the two changes :) |
|
Thanks! |
Reword tracklist editor warning strings from "used Various Artists on some tracks" to "used Various Artists for some tracks" and from "featured artists on the track titles" to "featured artists in the track titles".
Also rename a few variables for consistency.