Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBS-13917: Add new properties to avoid crashes #3481

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

reosarevok
Copy link
Member

Description

We need the beta server to support the same fields than production will be adding for works, in order to avoid clashing redis entries causing crashes (this caused issues while releasing beta that meant I had to revert it).

#1171

@reosarevok reosarevok added the Regression/Beta Bugs that are either on beta or new regressions and should be checked ASAP label Feb 18, 2025
Copy link
Member

@mwiencek mwiencek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine but maybe keep them in the same order as (including the added comment) #3480 to avoid merge conflicts.

@reosarevok reosarevok force-pushed the MBS-13917-beta-unstopper branch from 48027b4 to 34b9a78 Compare February 18, 2025 20:25
We need the beta server to still support the same fields than prod
is using for works, in order to avoid clashing redis entries causing crashes.
@reosarevok reosarevok force-pushed the MBS-13917-beta-unstopper branch from 34b9a78 to 91e7247 Compare February 18, 2025 20:26
@reosarevok reosarevok merged commit 3686a7b into metabrainz:beta Feb 18, 2025
1 of 2 checks passed
@reosarevok reosarevok deleted the MBS-13917-beta-unstopper branch February 18, 2025 21:02
reosarevok added a commit that referenced this pull request Feb 24, 2025
* beta:
  Translated using Weblate (Chinese (Simplified Han script))
  Translated using Weblate (Italian)
  Update translation files
  MBS-13917: Add new properties to avoid crashes (#3481)
  Update POT files using the production database
  Merge pull request #3472 from reosarevok/MBS-13929
  Merge pull request #3477 from reosarevok/MBS-13939
  Merge pull request #3478 from reosarevok/MBS-13938
  Merge pull request #3473 from reosarevok/MBS-13930
  Add ordering to `_find_authors_or_other_artists` roles
  Use proper query variable bindings in `Data::Edit::find_by_collection`
  MBS-13914: Validate vote arguments for voter edit search (#3464)
  MBS-13763: Add past year stats to the editors statistic page (#3465)
  MBS-13928: Use jaxsta.com instead of jaxsta.io (#3471)
  add --no-same-owner option to tar (#3456)
  MBS-13925: Instrument name erroneously displayed in link type autocomplete (#3467)
  Avoid spreading `key` props in `useTable` hook (#3476)
  Translated using Weblate (Chinese (Simplified Han script))
  Translated using Weblate (Chinese (Simplified Han script))
  Translated using Weblate (Russian)
  Translated using Weblate (Chinese (Simplified Han script))
  Translated using Weblate (Polish)
  Translated using Weblate (Italian)
  More direct `get_authorship_relationship_gids` implementation
  Rename "misc_artists" to "other_artists"
  MBS-8328: Split the role filter for artist works
  MBS-13917: Rename work "writers" to "authors"
  Get authorship rel gids from the DB
  Rename "composition" to "authorship"
  Add test for loading different subsets of work artists
  Drop unneeded work artist credit test SQL
  MBS-8328: Add the non-writer artists back as own column
  MBS-8328: Limit work writers to writing rels
  MBS-11916: Report for recordings marked both karaoke and instrumental (#2504)
  Merge pull request #3468 from derat/feat_error
  MBS-13920 (II): Detect feat. artists in titles when seeding (#3469)
  Use `qq` to avoid escaping "
  MBS-6502: Surround catno search with quotes
  MBS-13922: Add URL cleanup and validation for Naver Vibe (#3463)
  Move most filter find_by to right Data file
  MBS-8500: Add "not by me" filter for collection edit lists
  MBS-13597: Add release filter to label index pages
  Avoid warning when selected_artist_credit_id is missing
reosarevok added a commit that referenced this pull request Feb 24, 2025
* production:
  Translated using Weblate (Chinese (Simplified Han script))
  Translated using Weblate (Italian)
  Update translation files
  MBS-13917: Add new properties to avoid crashes (#3481)
  MBS-13917: Add new properties to avoid crashes (#3480)
  Translated using Weblate (Chinese (Simplified Han script))
  Translated using Weblate (Chinese (Simplified Han script))
  Translated using Weblate (Russian)
  Translated using Weblate (Chinese (Simplified Han script))
  Translated using Weblate (Polish)
  Translated using Weblate (Italian)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Regression/Beta Bugs that are either on beta or new regressions and should be checked ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants