MBS-13771: Filter edit search by entity type #3484
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I implemented this as a hopefully trivially reusable role, since this seems like a useful filter for every entity type with types.
Just reuses the code I added for RGs. There's *a lot* of work types though, so this sets a maximum size of 10 for the options list by default so that it doesn't take the whole page.
reosarevok
changed the title
This needs an extra join so it cannot use the role (well, it could, but it's probably useless to complicate the role significantly for this one case). Other than that, it's as straightforward as other types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MBS-13771
Description
This adds a way to filter edit searches by entity type. I implemented this because of a request to filter by the primary type of release groups, but since it's a trivially reusable role, and this seems like a useful filter for every entity type with types, I am adding it for every entity with types. RG secondary types don't use the role (they could in a similar way to
EntityArea, but I did not see the point of complicating the role significantly for a one-off) but other than that work the same as all other types.Testing
Manually, searching for edits with all kinds of type filters and making sure the results seem sensible.