Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codacy warnings #2581

Merged
merged 3 commits into from
Feb 21, 2025
Merged

Codacy warnings #2581

merged 3 commits into from
Feb 21, 2025

Conversation

zas
Copy link
Collaborator

@zas zas commented Feb 21, 2025

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

  • JIRA ticket (optional): PICARD-XXX

Solution

Action

Additional actions required:

  • Update Picard documentation (please include a reference to this PR)
  • Other (please specify below)

zas added 3 commits February 21, 2025 16:45
@zas
Declare variables to None to make pylint happier (mainly conditional …
ad87d4d 
…imports)
@zas
Declare pywintypes & win32api to None if not imported
68fd0c9 
Note: On Windows, the lack of those isn't really a good sign, so do not log anything and let the exception bubbles up
@zas
Disable pylint too-many-positional-arguments
6083d20
@zas zas requested a review from phw February 21, 2025 17:21
rdswift
rdswift approved these changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@rdswift rdswift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

phw
phw approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@phw phw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@zas zas merged commit 8b445aa into metabrainz:master Feb 21, 2025
49 checks passed
@zas zas deleted the codacy_warnings branch February 21, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phw phw phw approved these changes

@rdswift rdswift rdswift approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zas @phw @rdswift