Use pytest and PEP 517 build #2587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zas
reviewed
Feb 25, 2025
This removes the zip archive, as PEP 517 only specifies sdist archives in .tar.gz format.
phw
force-pushed
the
pytest-and-pip517-build
branch
from
56e39ca to
2ab56e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Attempt to reduce the direct calls to
setup.py.Solution
Remove
setup.py testcompletely and replace the calls withpytest.Build sdist / bdist packages with
python -m build.Note: As a side effect this removes the source builds in zip format, as PEP 517 only specifies .tar.gz as format. Do we need the zip source distribution? I think with public availability of the source in git and wide availability of extraction tools for .tar.gz even on Windows this is not really needed.
If we want to provide it we could add a CI step to also create a zip file.