Skip to content

enable or disable dragging based on overflow #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

enable or disable dragging based on overflow #1031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2d9e3f
enable or disable dragging based on overflow
pooriamo Feb 25, 2020
937164a
use this.viewport directly
pooriamo Feb 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions js/drag.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,8 @@ proto.updateDraggable = function() {
// disable dragging if less than 2 slides. #278
if ( this.options.draggable == '>1' ) {
this.isDraggable = this.slides.length > 1;
} else if (this.options.draggable === 'onOverflow') {
this.isDraggable = this.viewport.scrollWidth > this.viewport.offsetWidth;
} else {
this.isDraggable = this.options.draggable;
}
Expand Down
12 changes: 12 additions & 0 deletions sandbox/basic.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,18 @@ <h2>contain, few</h2>
<!-- <div class="cell n3">3</div> -->
</div>

<h2>contain, only draggable if overflow</h2>

<div class="container variable-width js-flickity"
data-flickity-options='{ "contain": true, "cellAlign": "left", "draggable": "onOverflow" }'>
<div class="cell n1">1</div>
<div class="cell n2">2</div>
<div class="cell n3">3</div>
<div class="cell n4">4</div>
<div class="cell n5">5</div>
<div class="cell n6">6</div>
</div>

<h2>watch, activate >900px</h2>

<div id="gallery5" class="container variable-width js-flickity"
Expand Down