Skip to content
This repository was archived by the owner on Aug 26, 2023. It is now read-only.

Workflow Added - Deploy to GitHub Pages #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Siddhant-K-code
Copy link

Build Status: Success

Please check, is it deployed?

@Siddhant-K-code
Copy link
Author

Siddhant-K-code commented Dec 9, 2020

Fixes #13 Hopefully

Copy link
Collaborator

@thealphadollar thealphadollar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the Pull Request. This looks cool to me to begin with.

Can you please help me understand how you have tested the action script?

Comment on lines +8 to +11
push:
branches: [ gh-pages ]
pull_request:
branches: [ gh-pages ]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have master here since we want the action to run when a push is done to the master branch. Also, If I remember correctly, push already takes care of merging pull requests.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants