WIP: Improve Result class - #555
Open
tshemsedinov wants to merge 1 commit into
Open
tshemsedinov wants to merge 1 commit into
tshemsedinov wants to merge 1 commit into
Conversation
tshemsedinov
commented
Sep 9, 2026
tshemsedinov
left a comment
tshemsedinov
left a comment
Member
Author
There was a problem hiding this comment.
update tests according to code changes
| class FrameParser { | ||
| static parse(buffer) { | ||
| if (buffer.length < 2) return Result.empty(); | ||
| if (buffer.length < 2) return Result.ok(null); |
Member
Author
There was a problem hiding this comment.
It is null by default so do not need to pass null, here and in all places like this
Comment on lines
+185
to
187
| return Result.fail( | ||
| new ParseError(PARSE_ERR_CODES.PROTOCOL_ERROR_COMMON, 'Protocol error'), | ||
| ); |
Member
Author
There was a problem hiding this comment.
use intermediate identifiers
Comment on lines
+18
to
20
| static fail(error) { | ||
| return new Result(null, error); | ||
| } |
Member
Author
There was a problem hiding this comment.
need an error by default
|
|
||
| static async fromAsync(fn) { | ||
| try { | ||
| return Result.ok(await fn()); |
Member
Author
There was a problem hiding this comment.
await at separate line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.