Skip to content

updated flow router support to reflect changed API in v1.8.0#3

Open
richsilv wants to merge 2 commits into
meteor-london:masterfrom
richsilv:patch-1
Open

updated flow router support to reflect changed API in v1.8.0#3
richsilv wants to merge 2 commits into
meteor-london:masterfrom
richsilv:patch-1

Conversation

@richsilv

Copy link
Copy Markdown
Contributor

No description provided.

@olizilla

Copy link
Copy Markdown
Member

No change to https://github.com/meteor-london/body-class/blob/master/package.js needed?

If this is an api change then we should bump the minor version number rather than patch.

@richsilv

Copy link
Copy Markdown
Contributor Author

Sorry, I don't really understand. We're updating the version number from 2.1.0 to 2.1.1 - are you saying we shouldn't be doing so? We have to bump it somehow in order to publish to Atmosphere.

@olizilla

Copy link
Copy Markdown
Member

https://github.com/meteor-london/body-class/blob/master/package.js lists

  api.use('meteorhacks:flow-router@1.4.0', 'client', { "weak": true })

I figured that as this PR is about adopting the flow-router 1.8 api, I'd assume an update to that line. I don't know for a fact that it's required, so thought I'd ask.

@richsilv

Copy link
Copy Markdown
Contributor Author

Ah, I see. Yes, that makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants