Allow colons in bracket parameter syntax #770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opqdonut
reviewed
Jan 9, 2026
Member
opqdonut
left a comment
opqdonut
left a comment
There was a problem hiding this comment.
one question, looks good to merge otherwise, thanks!
| (recur (concat ss (-static from to) (-wild to to')) (long (inc to')) (long (inc to'))))) | ||
|
|
||
| (and colon? (= \: c)) | ||
| (and colon? (= \: c) (not= \{ (get s (dec to)))) |
Member
There was a problem hiding this comment.
is the (not= ...) check really needed?
Member
There was a problem hiding this comment.
ah, it's needed when we have colon? but not bracket?
opqdonut
approved these changes
Jan 9, 2026
github-project-automation
bot
moved this from ⌛Waiting
to ✅ Done
in Metosin Open Source Backlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #748