-
Notifications
You must be signed in to change notification settings - Fork 72
Fix mibexsoftware#102 add renamed binary files and excluded file cases #118
base: master
Are you sure you want to change the base?
Conversation
Is it possible to merge this, @mrueegg ? |
b3f880e
to
ee7888b
Compare
ee7888b
to
fa3b325
Compare
Hi @mrueegg We're affected by this issue too. Please would you merge this PR? |
The same issue here. Could someone merge this PR? |
Hi there! I am also struggling with this issue. I tried to test this fix, but I am still seeing the same error. For what it's worth, here are my logs with debug enabled:
|
Hi @merrileemiller, could you post a little bit more of you stacktrace?
In this way we can add a specific test case. It's sufficent since We have found other unhandled row that start with X. @mrueegg please focus on this PR just a little bit |
1a63279
to
094272d
Compare
Sure! Here it is.
|
6e629cd
to
616c3a2
Compare
616c3a2
to
8b9e12d
Compare
Hi @merrileemiller , |
Thanks @LauraCameran ! It turns out I was not installing the plugin correctly so this was definitely a problem on my end. 🤦♀️
|
@LauraCameran @mrueegg do we know when we can expect this PR to be merged in? Seems like a lot of people are encountering this issue and this would be nice to have released |
@LauraCameran it seems this is your first PR. Can you please add @mrueegg as a review to this PR? |
There are two cases that were not included in the parsing:
File excluded by pattern "[pattern]"
and
Binary files a/[path] and b/[path] differ
With this fix both of them are handled.