Fix null and non submodules objects properties in state #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'm writing this PR to fix two issues I encountered with the current version (2.0.2) of this library.
The first is that the function
isFieldASubModule
insubmodule.ts
was trying to access a property from state properties initialized tonull
because in JStypeof null
is strangely equal to'object'
.The second one was a bit more tricky, as all object based state properties were all set to
{}
, even if they should have beenSet
orMap
.Feel free to tell me if this PR needs more work.