Skip to content

Commit

Permalink
revert slot name change (viamrobotics#596)
Browse files Browse the repository at this point in the history
  • Loading branch information
mrloureed authored Nov 1, 2024
1 parent 47c3ef6 commit 7a0dfa9
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ const shapeMap = {
selected={shapeMap[geometry.type]}
on:input={handleShapeSelect}
>
<svelte:fragment slot="label">Shape</svelte:fragment>
<svelte:fragment slot="legend">Shape</svelte:fragment>
</ToggleButtons>

{#if geometry.type === 'box'}
Expand Down
2 changes: 1 addition & 1 deletion packages/core/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@viamrobotics/prime-core",
"version": "0.0.163",
"version": "0.0.164",
"repository": {
"type": "git",
"url": "https://github.com/viamrobotics/prime.git",
Expand Down
8 changes: 4 additions & 4 deletions packages/core/src/lib/__tests__/toggle-button.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,15 +63,15 @@ describe('ToggleButtons', () => {
expect(onInput).not.toHaveBeenCalled();
});

it('Renders the legend correctly', () => {
it('Renders the label correctly', () => {
render(ToggleButtons, common);
expect(screen.getByText('Test toggle buttons')).toBeVisible();
});

it('Renders the legend correctly when disabled', () => {
it('Renders the label correctly when disabled', () => {
render(ToggleButtons, { ...common, disabled: true });

const legend = screen.getByText('Test toggle buttons');
expect(legend).toHaveClass('text-disabled-dark cursor-not-allowed');
const label = screen.getByText('Test toggle buttons');
expect(label).toHaveClass('text-disabled-dark cursor-not-allowed');
});
});
2 changes: 1 addition & 1 deletion packages/core/src/lib/__tests__/toggle-buttons.spec.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ export let disabled = false;
{disabled}
on:input
>
<svelte:fragment slot="label">Test toggle buttons</svelte:fragment>
<svelte:fragment slot="legend">Test toggle buttons</svelte:fragment>
</ToggleButton>
4 changes: 2 additions & 2 deletions packages/core/src/lib/toggle-button.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ const handleClick = (value: string) => {
class={cx('flex', extraClasses)}
{...$$restProps}
>
{#if $$slots.label}
{#if $$slots.legend}
<label
class={cx(
cx('mb-1 flex text-xs', {
Expand All @@ -69,7 +69,7 @@ const handleClick = (value: string) => {
})
)}
>
<slot name="label" />
<slot name="legend" />
</label>
{/if}

Expand Down
6 changes: 3 additions & 3 deletions packages/core/src/routes/+page.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -1840,7 +1840,7 @@ const onHoverDelayMsInput = (event: Event) => {
selected={toggleButtonSelecteds[1]}
on:input={createHandleToggleButtons(1)}
>
<svelte:fragment slot="label">Preselected toggle</svelte:fragment>
<svelte:fragment slot="legend">Preselected toggle</svelte:fragment>
</ToggleButtons>

<ToggleButtons
Expand All @@ -1849,7 +1849,7 @@ const onHoverDelayMsInput = (event: Event) => {
selected={toggleButtonSelecteds[2]}
on:input={createHandleToggleButtons(2)}
>
<svelte:fragment slot="label">Disabled toggle</svelte:fragment>
<svelte:fragment slot="legend">Disabled toggle</svelte:fragment>
</ToggleButtons>

<ToggleButtons
Expand All @@ -1858,7 +1858,7 @@ const onHoverDelayMsInput = (event: Event) => {
selected={toggleButtonSelecteds[3]}
on:input={createHandleToggleButtons(3)}
>
<svelte:fragment slot="label">Full width</svelte:fragment>
<svelte:fragment slot="legend">Full width</svelte:fragment>
</ToggleButtons>
</div>

Expand Down

0 comments on commit 7a0dfa9

Please sign in to comment.