New Features Added! (See details for explanations) #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... lfs might not be an option 👎
+ some refactoring
# Conflicts: # filetree.lua
(view-refactor branch merged)
Fixes 2 bugs, adds gitignore and dotfile hiding, and adds a Changelog
Also fixed the wrong year on the v3.0.0 changelog
Fixes block comments not being parsed till you move your cursor into them. Fixes an errant tab being inserted in the newly opened file. Requires Micro >= v1.4.0 since it makes use of NewBufferFromFile to fix the block comment issue. Ref zyedidia/micro#992 for all discussion on this.
Read the CHANGELOG.md for full info. This version is just bugfixes, but requires Micro >= v1.4.0
The Micro function call 'NewBufferFromFile' was used in an assumption it was compatible with v1.4.0, but it's only in nightly.
Doesn't change anything functionally.
Also some minor optimizations, and a line-break on the README. We don't need to save the GetOption call. The compress_target function can also be canceled early to prevent an unnecessary refresh.
No idea why I was doing it, but I remember reading to do it in a random forum...
The return would exit early on a 'delete_y' call, causing the item not to be removed from the list.
Thanks to @avently, the left arrow will now jump to the parent if not minimizing, and the '..' can be jumped to as a parent of root files/dirs.
…ng files, however: in function try_open_at_y.
Very minor change to not start the loops index at 0, since Lua uses 1-based index. The rest is formatting changes from luafmt. Resolves #33
Fixes #36 The Golang path.Base() doesn't work on Windows, while its filepath.Base() does.
Performance improvement Thanks to @jackwilsdon, ref PR #37
Also updated CHANGELOG for new option.
* io.popen isn't working for me - either it's an issue specific to the latest Micro, or possibly something with my Termux environment. The result was git query failures with filemanager-showignored=false and stack dumps from deref'ing nil. The latest Micro has new functions for running shell commands, which we'd want to use anyway, and also resolves the issue, so I switched to those. * Along the way also running a simpler git query that avoids a full status query just to ask if cwd is a git workdir or not.
Hopefully more concise/understandable.
Closes #46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New features added!