Skip to content

Conversation

@mflynn-lanl
Copy link
Contributor

@mflynn-lanl mflynn-lanl commented Oct 23, 2025

On this branch, I created 3 new endpoints to get sequencing project records, get a record by project name, create a record. I also created associated tests and models.

Details

N/A

Related issue(s)

Fixes issue #1291

Related subsystem(s)

  • Runtime API (except the Minter)
  • Minter
  • Dagster
  • Project documentation (in the docs directory)
  • Translators (metadata ingest pipelines)
  • MongoDB migrations
  • Other

Testing

  • I tested these changes (explain below)
  • I did not test these changes

I tested these changes by...

Documentation

  • I have not checked for relevant documentation yet (e.g. in the docs directory)
  • I have updated all relevant documentation so it will remain accurate
  • Other (explain below)

Maintainability

  • Every Python function I defined includes a docstring (test functions are exempt from this)
  • Every Python function parameter I introduced includes a type hint (e.g. study_id: str)
  • All "to do" or "fix me" Python comments I added begin with either # TODO or # FIXME
  • I used black to format all the Python files I created/modified
  • The PR title is in the imperative mood (e.g. "Do X") and not the declarative mood (e.g. "Does X" or "Did X")

@mflynn-lanl mflynn-lanl requested a review from hesspnnl October 23, 2025 01:47
@mflynn-lanl mflynn-lanl linked an issue Oct 23, 2025 that may be closed by this pull request
hesspnnl

This comment was marked as resolved.

@eecavanna

This comment was marked as outdated.

@eecavanna eecavanna requested a review from Copilot October 23, 2025 15:24

This comment was marked as outdated.

@eecavanna eecavanna requested a review from Copilot November 1, 2025 19:51

This comment was marked as outdated.

@eecavanna eecavanna changed the title 1291 create sequencing project endpoints Implement API endpoints for creating, retrieving, and listing JGISequencingProjects Nov 1, 2025
@eecavanna

This comment was marked as resolved.

@eecavanna eecavanna changed the title Implement API endpoints for creating, retrieving, and listing JGISequencingProjects Implement API endpoints for creating and retrieving JGISequencingProjects Nov 2, 2025
@eecavanna

This comment was marked as resolved.

@eecavanna eecavanna dismissed hesspnnl’s stale review November 4, 2025 01:54

Dismissing review that requested changes since all requested changes were made. This will enable merge.

@eecavanna
Copy link
Collaborator

eecavanna commented Nov 4, 2025

Hi @aclum, are you OK with this branch being merged into main during this week (i.e. pre-release testing week)? This will add a set of endpoints related to JGI sequencing projects. I have reviewed it and am comfortable with it being merged in (now or later), but I don't know as much about the context it was developed in (e.g. the state of the client people expect to interact with these endpoints).

@mflynn-lanl mflynn-lanl merged commit c9d419a into main Nov 4, 2025
2 checks passed
@mflynn-lanl mflynn-lanl deleted the 1291-create-sequencing-project-endpoints branch November 4, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create sequencing project table-related endpoints

4 participants