-
Notifications
You must be signed in to change notification settings - Fork 28
GitHub Actionsワークフローのメンテナンス #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughGitHub Actions ワークフローを更新し、アクション参照を特定コミットSHAへ変更、トリガーのクォート形式を統一、CI を静的チェックと拡張された Node.js マトリックス(18.x,20.x,22.x,24.x)で分離。package.json にフォーマット・型チェックスクリプトを追加し、テストモックの MSW 呼び出しを整形/分割。 Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant GH as GitHub Actions
participant Repo as Repository
participant Node as Node matrix jobs
rect rgb(230,245,255)
Note over GH,Repo: Push / pull_request / release trigger
end
GH->>Repo: checkout (specific SHA)
GH->>GH: static-check job
GH->>Node: build-and-test job (matrix: 18x,20x,22x,24x)
Node->>GH: run Build
Node->>GH: run Unit Tests
GH->>GH: publish (release workflow)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 確認が必要な箇所:
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (6)
Comment |
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-node@v4 | ||
| - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 | ||
| - uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
バージョンアップと同時に、pinactでコミットハッシュで固定しました。
| node-version: '18.x' | ||
| registry-url: 'https://registry.npmjs.org' | ||
| node-version-file: ".node-version" | ||
| registry-url: "https://registry.npmjs.org" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
バージョン指定を .node-version ファイルを読むようにしました。
追伸: フォーマットかかっていて、クオーテーションが変わってますが気にせずで。
| strategy: | ||
| matrix: | ||
| node-version: [18.x, 20.x] | ||
| node-version: [18.x, 20.x, 22.x, 24.x] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
現行で、24まで出ているので、加えておきました。
dc7290
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
良さそうです!
コードチェック強化: format, typecheck追加, eslintにtestsディレクトリを対象に加える
変更概要
actions/checkoutとactions/setup-nodeの最新を利用する.github/workflows/ci.ymlstrategy.matrix.node-versionに 22.x と 24.x を追記.github/workflows/release.yml.node-versionファイルを読む先に #94 をみてください。
Summary by CodeRabbit
Chores
Chores(パッケージ)
Tests