-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gradle and dependencies #1949
Conversation
You're removing the embedding of safe-parcel into play-services-basement. This is required to ensure the same module structure as used by original Google modules. If there is no way to implement embedding ("fat aar") with AGP 8, you'd need to copy the whole safe-parcelable library over to play-services-basement (which would also allow to provide the same API for safe parcel as provided by Google's play-services-basement) |
Thanks for the info. Will attempt to addres this |
Change-Id: Ief18cb82ddfa389561c7c440b90886f8499fca53
Change-Id: Iccdf9db19017f9075712fb4e3c636a2cbd3ee9f8
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you often adjusted the version of androidx library dependencies in non-core packages. These typically reflect the dependency required from the respective original Google library, as is typically written in a comment above those dependencies. As these are api scope dependencies and thus part of the public API of those packages, they need to match to ensure full compatibility.
You can easily check the version of those dependencies that you need to use via https://mvnrepository.com/ (e.g. for play-services-auth-base, the version of andoidx.collection must be 1.0.0 as can be seen on https://mvnrepository.com/artifact/com.google.android.gms/play-services-auth-base/18.0.9). If you want to make sure a later version of the library is effectively bundled in GmsCore, you can reference that library from the corresponding core package.
Superseded by 4c32a11 |
No description provided.